gmail (major) Additional fixes and improvements #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidDurman
force-pushed
the
gmail-fixes
branch
from
45472fe to
0f460a5
Compare
DavidDurman
force-pushed
the
gmail-fixes
branch
from
df58721 to
e52caea
Compare
…tachment belongs to
…tachment belongs to. Introduce a Download toggle to choose if we want to download attachment file data.
DavidDurman
force-pushed
the
gmail-fixes
branch
from
fd21a99 to
0f9e011
Compare
vtalas
requested changes
Jan 24, 2025
| }, | ||
|
|
||
| getNewMessages(latestMessageId, messages) { | ||
| getNewMessages(latestMessageInternalDate, messages) { |
|
|
||
| // Fetch attachments from emails. | ||
| const output = []; | ||
| await Promise.map(emails, async (email) => { |
There was a problem hiding this comment.
"message": "Promise.map is not a function"
| }, | ||
|
|
||
| getNewMessages(latestMessageId, messages) { | ||
| getNewMessages(latestMessageInternalDate, messages) { |
There was a problem hiding this comment.
getNewMessages is not used anywhere
| @@ -32,40 +31,27 @@ | |||
| "type": "string" | |||
| } | |||
| }, | |||
| "required": ["messageId", "attachmentId", "fileName"] | |||
| "required": ["messageId", "attachmentId"] | |||
There was a problem hiding this comment.
fileName is not reuquired, however flow throws the missing file name param if it's not provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.